Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix hidden inset titleBar on macOS #992

Merged
merged 1 commit into from Oct 31, 2018
Merged

fix hidden inset titleBar on macOS #992

merged 1 commit into from Oct 31, 2018

Conversation

ztoben
Copy link
Contributor

@ztoben ztoben commented Oct 29, 2018

Fixes #976

Before:

screen shot 2018-10-29 at 8 10 31 am

After:

screen shot 2018-10-29 at 8 09 30 am

@ztoben
Copy link
Contributor Author

ztoben commented Oct 29, 2018 •
edited

Anyone able to help me with the build failure? Not sure what that's about. This works for me locally on MacOS Mojave.

@averissimo, could you take a look at this?

@averissimo
Copy link
Member

@ztoben can you rebase from master please?

I published the code for the latest release and did not update master.

The problem with the build comes from this.

@averissimo averissimo merged commit e461b79 into yakyak:master Oct 31, 2018
@averissimo
Copy link
Member

Nevermind, it's been merged.

Thanks for the contribution!! 👍

1 similar comment
@averissimo
Copy link
Member

Nevermind, it's been merged.

Thanks for the contribution!! 👍

@sriharshachilakapati sriharshachilakapati mentioned this pull request Nov 9, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ztoben @averissimo