Improvements in notifications -- Adds yakyak icon and sound in linux, avatar in Mac OS X #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
averissimo
changed the title
averissimo
force-pushed
the
feature-notifications-icon-and-sound
branch
from
c62e75e
to
966d8a5
Compare
averissimo
force-pushed
the
feature-notifications-icon-and-sound
branch
from
966d8a5
to
df49a27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Big thanks to @Silveran for helping testing this in #464!!!
Adds YakYak icon to notifications in all OS but Mac OS X
Notification system must support, but I believe all do
Adds user avatar to message notification [only for Mac OS X]
It is only supported in the notification app of Mac OS X
Adds new message sound to systems that don't support sound in notifications
Click here to go to author's page
This can be changed later on :)
All this is configurable in options
Image shows default options