2 fixes on new conversations and removal #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it wasn't changing anything, just deleting from convlist
|
had to make a correction to part of this commit as unread count was not correct. pushed to master see 7b97e16 |
This was referenced Dec 4, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New conversations via new message received
Handle to add client_conversation was already available, but it was a bit conservative (only adding when conversation did not exist)
When a conversation starts via a new message received a conv. skeleton is created thus rendering the handle useless
Removal of conversation
after confirming that we want to remove, changes to top conversation
previous behavior kept interface to remove user (that was already removed)