Corrections on feature 'seen' #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
averissimo
changed the title
There was a longstanding bug that a conversation would start requesting history and scroll up. This was caused because there would be 2 elements with the same id, the message in the message pane, and the message snippet in the conversation list pane. corrected by adding a prefix to the message in the list pane, example: "list_<event_id>" To make sure we have an updated view of the read state, we get conversation metadata everytime we set focus on a conversation. and only parse the metadata.
averissimo
force-pushed
the
feature-seen
branch
from
3f88795
to
ed8ad79
Compare
|
awesome |
|
It's working without problems so far, change in id didn't seem to break anything :) Message snippet is also updating with conversation |
averissimo
changed the title
|
@davibe been using yakyak a lot today since the last commit was pushed and nothing seems broken :) should be ready to be merged and tested in a pre-release :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correction from new feature
Bug: Show only last seen avatar is not working properly once you start to scroll up and history is fetched. Duplicate avatars are shown and sometimes the last one is not shown.
Solution: Show all seen avatars throughout the conversation
Also makes feature more robust, everytime the conversation gets focus it also requests an update on the metadata and updates it, instead of relying on getting it from history
General correction in YakYak
Bug: I've been noticing through my usage of YakYak that sometimes YakYak starts scrolling up alone without input.
I found out why today why while implementing a more predicted way of getting the read_state: We are using duplicate ids in the interface.
The message id is used in message pane, but also in the conversation list on the left. And this id is important as it is used when redrawing the conversation (to refresh it and get back at the same point).
Solution: Message snippet id now has a prefix