More rigorous testing for homebrew #697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of just checking of existence of the `brew` command, make sure that the existsing `brew ls --versions` command does not end with error. Still not really a proper fix for people with a different `brew` command than homebrew, but it fixes the build in such circumstances at least. Signed-off-by: Martin Kletzander <nert.pinx@gmail.com>
|
Fixed a typo in a commit message (hence the force-push). |
|
Thank you for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of just checking of existence of the
brewcommand, make sure that theexistsing
brew ls --versionscommand does not end with error. Still notreally a proper fix for people with a different
brewcommand than homebrew,but it fixes the build in such circumstances at least.
Signed-off-by: Martin Kletzander nert.pinx@gmail.com