Skip to content

Commit

Permalink
"--run" prefix is reserved, so change flag name
Browse files Browse the repository at this point in the history
  • Loading branch information
yamachu committed Jun 27, 2022
1 parent ee820c5 commit 3e2476c
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 2 deletions.
3 changes: 3 additions & 0 deletions src/mono/wasm/test-main.js
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,7 @@ function initRunArgs() {
runArgs.enableGC = runArgs.enableGC === undefined ? true : runArgs.enableGC;
runArgs.diagnosticTracing = runArgs.diagnosticTracing === undefined ? false : runArgs.diagnosticTracing;
runArgs.debugging = runArgs.debugging === undefined ? false : runArgs.debugging;
runArgs.deepWorkDir = runArgs.deepWorkDir === undefined ? false : runArgs.deepWorkDir;
// default'ing to true for tests, unless debugging
runArgs.forwardConsole = runArgs.forwardConsole === undefined ? !runArgs.debugging : runArgs.forwardConsole;
}
Expand Down Expand Up @@ -209,6 +210,8 @@ function processQueryArguments(incomingArguments) {
} else {
console.warn("--fetch-random-delay only works on browser")
}
} else if (currentArg == ("--deep-work-dir")) {
runArgs.deepWorkDir = true;
} else {
break;
}
Expand Down
2 changes: 1 addition & 1 deletion src/tests/BuildWasmApps/Wasm.Build.Tests/BuildTestBase.cs
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ public BuildTestBase(ITestOutputHelper output, SharedBuildPerTestClassFixture bu
}

bool runDeepWorkDir = false;
if (extraXHarnessMonoArgs?.Contains("--run-deep-work-dir=true") ?? false)
if (extraXHarnessMonoArgs?.Contains("--deep-work-dir") ?? false)
{
runDeepWorkDir = true;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ public void RunOutOfAppBundle(BuildArgs buildArgs, RunHost host, string id)
}
}

RunAndTestWasmApp(buildArgs, expectedExitCode: 42, host: host, id: id, extraXHarnessMonoArgs: "--run-deep-work-dir=true");
RunAndTestWasmApp(buildArgs, expectedExitCode: 42, host: host, id: id, extraXHarnessMonoArgs: "--deep-work-dir");
}
}
}

0 comments on commit 3e2476c

Please sign in to comment.