Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arrays For Commands #616

Open
lorenzo-gomez-windhover opened this issue Oct 1, 2021 · 5 comments
Open

Arrays For Commands #616

lorenzo-gomez-windhover opened this issue Oct 1, 2021 · 5 comments

Comments

@lorenzo-gomez-windhover
Copy link
Contributor

Hi there,

Hope you are all doing well.

Are there any plans for adding support for ArrayArgumentType?

Thanks
Lorenzo

fqqb added a commit to fqqb/yamcs that referenced this issue Sep 20, 2022
@fqqb
Copy link
Member

fqqb commented Oct 4, 2022

As of v5.7.7, single-dimensional array arguments are supported.

  • XTCE StartingIndex has to be 0.
  • XTCE EndingIndex can be specified using either FixedValue or DynamicValue (argument or parameter)

Keeping open because multi-dimensional array arguments will not yet work.

@snthzm
Copy link

snthzm commented Sep 16, 2024

@fqqb any updates on multi-dimensional array supports ?

@fqqb
Copy link
Member

fqqb commented Sep 17, 2024

Since this issue, the UI should work for multi-dimensional array arguments (or it did at some point).
But the backend is for @xpromache to have a look at. From what I remember, there's a pending issue relating to determining the correct dimension lengths.

In practice, we don't really see this kind of arguments in our projects, so it's never been prioritized.

@snthzm
Copy link

snthzm commented Sep 17, 2024

I was wondering because ArrayArgumentType taking another ArrayArgumentType as an arrayTypeRef doesn't seems to be supported by the Commanding manager (cannot extract the data I put for the inner array element) with the following error message :
RouteHandler 16: Responding '400 Bad Request': Cannot assign value to packetStoreSequence: bad size for array of type TC-XX-X-TCNAME__packetStoreSequence__packetStores__el; expected size : 1, actual size: 0
Have you noticed that ?

@xpromache
Copy link
Member

No, as Fabian said we haven't been using array arguments much.

If you want to speed up the resolution, please create a concrete test case including an MDB definition which can easily reproduce the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants