Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary rules from .gitignore #118

Closed
fotonmoton opened this issue May 29, 2018 · 5 comments
Closed

Remove unnecessary rules from .gitignore #118

fotonmoton opened this issue May 29, 2018 · 5 comments

Comments

@fotonmoton
Copy link

fotonmoton commented May 29, 2018

Remove run*, test* and example-deconstructor* example-reformatter* rules from .gitignore.

Case:

  1. Download lib from Github.
  2. Add lib to your project
  3. Push your project to Github.
  4. Pull your project from Github.
  5. Try to compile your project with libyaml.

Expected result:

  • All comiles and work

Actual result:

  • Libyaml doesn't compiles because of missing files (test files)

Error that I get:
make[2]: Entering directory '/tmp/rt/lib/libyaml/tests' make[2]: *** No rule to make target 'run-scanner.c', needed by 'run-scanner.o'. Stop.

@perlpunk
Copy link
Member

perlpunk commented Jun 6, 2019

Note: I don't know why the run-* scripts were originally added to .gitignore.

A workaround: do git add -f libyaml, this will also add files that would be igored otherwise

@perlpunk
Copy link
Member

I see this was changed in d050fe3
Seems this was an oversight.

@perlpunk
Copy link
Member

Created #177
Thanks!

@fotonmoton
Copy link
Author

@perlpunk, no problem!

@perlpunk
Copy link
Member

perlpunk commented Jun 1, 2020

Released 0.2.5!

@perlpunk perlpunk closed this as completed Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants