Support static and dynamic libraries #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
jakirkham
force-pushed
the
add_dll_support
branch
from
f9fa003
to
dfae984
Compare
jakirkham
changed the title
|
@jakirkham can you rebase this please? |
|
@sigmavirus24, I rebased it and pushed to branch Wonder how to test this. @jakirkham? |
|
I'm not really a Windows expert. I asked others for advice on how to get a dynamic and a static library and this is what they suggested. Suppose one could do a file test to make sure it exists. Additionally one could try compiling some simple code and running it. What are your thoughts? |
|
Also it looks like |
|
@jakirkham This was not the canonical source when you submitted the pull request. When this became the canonical source, the history was rewritten when the repository was reimported. |
jakirkham
force-pushed
the
add_dll_support
branch
from
dfae984
to
300bd3f
Compare
|
Alright, I have tried to rebase this. Please let me know what you think. |
|
Thanks @jakirkham! |
sigmavirus24
pushed a commit
to sigmavirus24/libyaml
that referenced
this pull request
Apr 6, 2017
Issues yaml#10, #400
nitzmahone
added a commit
to nitzmahone/libyaml
that referenced
this pull request
Mar 2, 2019
* also changed name back to original default of yaml, as the change in yaml#10 to `yaml_static` broke things that relied on that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch changes the CMake build so that it includes both static and dynamic libraries.