Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow override of Windows static lib name #136

Merged
merged 1 commit into from
Mar 4, 2019

Conversation

nitzmahone
Copy link
Member

@nitzmahone nitzmahone commented Mar 2, 2019

  • previous change to yaml_static.lib in Support static and dynamic libraries #10 breaks things that expect yaml.lib; change it back, but allow an override via -DYAML_STATIC_LIB_NAME=whatever when generating makefiles.

* also changed name back to original default of yaml, as the change in yaml#10 to `yaml_static` broke things that relied on that
Copy link
Member

@perlpunk perlpunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nitzmahone nitzmahone merged commit e7a5f0b into yaml:master Mar 4, 2019
@nitzmahone nitzmahone mentioned this pull request Mar 4, 2019
3 tasks
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Apr 1, 2019
Changes
=======

* yaml/libyaml#95 -- build: do not install config.h
* yaml/libyaml#97 -- appveyor.yml: fix Release build
* yaml/libyaml#103 -- Remove unused code in yaml_document_delete
* yaml/libyaml#104 -- Allow colons in plain scalars inside flow collections
* yaml/libyaml#109 -- Fix comparison in tests/run-emitter.c
* yaml/libyaml#117 -- Fix typo error
* yaml/libyaml#119 -- The closing single quote needs to be indented...
* yaml/libyaml#121 -- fix token name typos in comments
* yaml/libyaml#122 -- Revert removing of open_ended after top level plain scalar
* yaml/libyaml#125 -- Cherry-picks from PR 27
* yaml/libyaml#135 -- Windows/C89 compatibility
* yaml/libyaml#136 -- allow override of Windows static lib name
Jehops pushed a commit to Jehops/freebsd-ports-legacy that referenced this pull request Apr 11, 2019
Fix portlint errors in Makefile

Changes in 0.2.2:
* yaml/libyaml#95 -- build: do not install config.h
* yaml/libyaml#97 -- appveyor.yml: fix Release build
* yaml/libyaml#103 -- Remove unused code in yaml_document_delete
* yaml/libyaml#104 -- Allow colons in plain scalars inside flow collections
* yaml/libyaml#109 -- Fix comparison in tests/run-emitter.c
* yaml/libyaml#117 -- Fix typo error
* yaml/libyaml#119 -- The closing single quote needs to be indented...
* yaml/libyaml#121 -- fix token name typos in comments
* yaml/libyaml#122 -- Revert removing of open_ended after top level plain scalar
* yaml/libyaml#125 -- Cherry-picks from PR 27
* yaml/libyaml#135 -- Windows/C89 compatibility
* yaml/libyaml#136 -- allow override of Windows static lib name


git-svn-id: svn+ssh://svn.freebsd.org/ports/head@498674 35697150-7ecd-e111-bb59-0022644237b5
uqs pushed a commit to freebsd/freebsd-ports that referenced this pull request Apr 11, 2019
Fix portlint errors in Makefile

Changes in 0.2.2:
* yaml/libyaml#95 -- build: do not install config.h
* yaml/libyaml#97 -- appveyor.yml: fix Release build
* yaml/libyaml#103 -- Remove unused code in yaml_document_delete
* yaml/libyaml#104 -- Allow colons in plain scalars inside flow collections
* yaml/libyaml#109 -- Fix comparison in tests/run-emitter.c
* yaml/libyaml#117 -- Fix typo error
* yaml/libyaml#119 -- The closing single quote needs to be indented...
* yaml/libyaml#121 -- fix token name typos in comments
* yaml/libyaml#122 -- Revert removing of open_ended after top level plain scalar
* yaml/libyaml#125 -- Cherry-picks from PR 27
* yaml/libyaml#135 -- Windows/C89 compatibility
* yaml/libyaml#136 -- allow override of Windows static lib name


git-svn-id: svn+ssh://svn.freebsd.org/ports/head@498674 35697150-7ecd-e111-bb59-0022644237b5
uqs pushed a commit to freebsd/freebsd-ports that referenced this pull request Apr 11, 2019
Fix portlint errors in Makefile

Changes in 0.2.2:
* yaml/libyaml#95 -- build: do not install config.h
* yaml/libyaml#97 -- appveyor.yml: fix Release build
* yaml/libyaml#103 -- Remove unused code in yaml_document_delete
* yaml/libyaml#104 -- Allow colons in plain scalars inside flow collections
* yaml/libyaml#109 -- Fix comparison in tests/run-emitter.c
* yaml/libyaml#117 -- Fix typo error
* yaml/libyaml#119 -- The closing single quote needs to be indented...
* yaml/libyaml#121 -- fix token name typos in comments
* yaml/libyaml#122 -- Revert removing of open_ended after top level plain scalar
* yaml/libyaml#125 -- Cherry-picks from PR 27
* yaml/libyaml#135 -- Windows/C89 compatibility
* yaml/libyaml#136 -- allow override of Windows static lib name
kwm81 pushed a commit to freebsd/freebsd-ports-gnome that referenced this pull request Apr 13, 2019
Fix portlint errors in Makefile

Changes in 0.2.2:
* yaml/libyaml#95 -- build: do not install config.h
* yaml/libyaml#97 -- appveyor.yml: fix Release build
* yaml/libyaml#103 -- Remove unused code in yaml_document_delete
* yaml/libyaml#104 -- Allow colons in plain scalars inside flow collections
* yaml/libyaml#109 -- Fix comparison in tests/run-emitter.c
* yaml/libyaml#117 -- Fix typo error
* yaml/libyaml#119 -- The closing single quote needs to be indented...
* yaml/libyaml#121 -- fix token name typos in comments
* yaml/libyaml#122 -- Revert removing of open_ended after top level plain scalar
* yaml/libyaml#125 -- Cherry-picks from PR 27
* yaml/libyaml#135 -- Windows/C89 compatibility
* yaml/libyaml#136 -- allow override of Windows static lib name
swills pushed a commit to swills/freebsd-ports that referenced this pull request Apr 14, 2019
Fix portlint errors in Makefile

Changes in 0.2.2:
* yaml/libyaml#95 -- build: do not install config.h
* yaml/libyaml#97 -- appveyor.yml: fix Release build
* yaml/libyaml#103 -- Remove unused code in yaml_document_delete
* yaml/libyaml#104 -- Allow colons in plain scalars inside flow collections
* yaml/libyaml#109 -- Fix comparison in tests/run-emitter.c
* yaml/libyaml#117 -- Fix typo error
* yaml/libyaml#119 -- The closing single quote needs to be indented...
* yaml/libyaml#121 -- fix token name typos in comments
* yaml/libyaml#122 -- Revert removing of open_ended after top level plain scalar
* yaml/libyaml#125 -- Cherry-picks from PR 27
* yaml/libyaml#135 -- Windows/C89 compatibility
* yaml/libyaml#136 -- allow override of Windows static lib name


git-svn-id: svn+ssh://svn.freebsd.org/ports/head@498674 35697150-7ecd-e111-bb59-0022644237b5
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request May 19, 2019
Changes
=======

* yaml/libyaml#95 -- build: do not install config.h
* yaml/libyaml#97 -- appveyor.yml: fix Release build
* yaml/libyaml#103 -- Remove unused code in yaml_document_delete
* yaml/libyaml#104 -- Allow colons in plain scalars inside flow collections
* yaml/libyaml#109 -- Fix comparison in tests/run-emitter.c
* yaml/libyaml#117 -- Fix typo error
* yaml/libyaml#119 -- The closing single quote needs to be indented...
* yaml/libyaml#121 -- fix token name typos in comments
* yaml/libyaml#122 -- Revert removing of open_ended after top level plain scalar
* yaml/libyaml#125 -- Cherry-picks from PR 27
* yaml/libyaml#135 -- Windows/C89 compatibility
* yaml/libyaml#136 -- allow override of Windows static lib name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants