Add packaging/docker-dist to Makefile.am #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitzmahone
reviewed
Apr 4, 2019
There was a problem hiding this comment.
Personally, I'd prefer to have the packaging stuff self-contained within the branch, so that changes can be tracked more sanely and any PRs that affect packaging can be one-shot instead of two... But if we're not going to do it all together, this + the contents of the packaging branch LGTM. Thanks @perlpunk !
ingydotnet
reviewed
Apr 5, 2019
Makefile.am
Outdated
| @@ -34,3 +34,10 @@ tests/run-test-suite: | |||
| -git branch --track run-test-suite origin/run-test-suite | |||
| -git worktree prune | |||
| git worktree add $@ run-test-suite | |||
|
|
|||
| packaging: | |||
| git branch --track packaging origin/packaging | |||
There was a problem hiding this comment.
-git branch --track $@ origin/$@
The leading - will keep it from stopping if the command fails because it is already done.
|
@perlpunk I like this. Added a few Makefile tweaks. @nitzmahone I hear you, but I don't like churn in libyaml. Once this stabilizes, we can consider integrating it into master. |
perlpunk
force-pushed
the
perlpunk/add-packaging
branch
from
1aaa589
to
ad3b3cb
Compare
|
I added a test-pyyaml target to the packaging branch. this will automatically run the pyyaml tests |
perlpunk
force-pushed
the
perlpunk/add-packaging
branch
from
ad3b3cb
to
b7e0edf
Compare
perlpunk
force-pushed
the
perlpunk/add-packaging
branch
from
b7e0edf
to
510181e
Compare
ingydotnet
approved these changes
Apr 18, 2020
uqs
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Apr 22, 2020
libyaml release changes: - yaml/libyaml#143 Add packaging/docker-dist to Makefile.am - yaml/libyaml#174 Fix logic for document end before directive FreeBSD port improvement: - Enable make test target - Use correct license file - Switch download mirror to HTTPS PR: 245813 Submitted by: daniel.engberg.lists@pyret.net git-svn-id: svn+ssh://svn.freebsd.org/ports/head@532485 35697150-7ecd-e111-bb59-0022644237b5
uqs
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Apr 22, 2020
libyaml release changes: - yaml/libyaml#143 Add packaging/docker-dist to Makefile.am - yaml/libyaml#174 Fix logic for document end before directive FreeBSD port improvement: - Enable make test target - Use correct license file - Switch download mirror to HTTPS PR: 245813 Submitted by: daniel.engberg.lists@pyret.net
Jehops
pushed a commit
to Jehops/freebsd-ports-legacy
that referenced
this pull request
Apr 22, 2020
libyaml release changes: - yaml/libyaml#143 Add packaging/docker-dist to Makefile.am - yaml/libyaml#174 Fix logic for document end before directive FreeBSD port improvement: - Enable make test target - Use correct license file - Switch download mirror to HTTPS PR: 245813 Submitted by: daniel.engberg.lists@pyret.net git-svn-id: svn+ssh://svn.freebsd.org/ports/head@532485 35697150-7ecd-e111-bb59-0022644237b5
ericbsd
pushed a commit
to ghostbsd/ghostbsd-ports
that referenced
this pull request
Apr 22, 2020
libyaml release changes: - yaml/libyaml#143 Add packaging/docker-dist to Makefile.am - yaml/libyaml#174 Fix logic for document end before directive FreeBSD port improvement: - Enable make test target - Use correct license file - Switch download mirror to HTTPS PR: 245813 Submitted by: daniel.engberg.lists@pyret.net
bungle
added a commit
to Kong/kong
that referenced
this pull request
May 22, 2020
### Summary - yaml/libyaml#143 Add packaging/docker-dist to Makefile.am - yaml/libyaml#174 Fix logic for document end before directive
bungle
added a commit
to Kong/kong
that referenced
this pull request
May 22, 2020
### Summary - yaml/libyaml#143 Add packaging/docker-dist to Makefile.am - yaml/libyaml#174 Fix logic for document end before directive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow to
make distin a reliable way inside a dockercontainer.
The docker stuff is currently put into its own branch
packaging.