Port bug fix from Perl binding #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code was disabled in Perl binding for breaking tests. Kirill said on IRC: < rz> ingy: i'm not sure why i set open_ended in yaml_emitter_write_plain_scalar
ingydotnet
force-pushed
the
bug/open_ended
branch
from
9e58201
to
56400d9
Compare
|
It seems to tell the emitter to output Line 652 in 56400d9 |
sigmavirus24
pushed a commit
to sigmavirus24/libyaml
that referenced
this pull request
Apr 6, 2017
straight-shoota
added a commit
to straight-shoota/crystal
that referenced
this pull request
Jun 28, 2018
libyaml 0.2.1 removed the errorneously written document end marker (`...`) after some scalars in root context (see yaml/libyaml#18). Earlier libyaml releases still write the document end marker and this is hard to fix on Crystal's side. So we just ignore it and adopt the specs accordingly to coincide with the used libyaml version.
This was referenced Jun 28, 2018
bcardiff
pushed a commit
to crystal-lang/crystal
that referenced
this pull request
Jun 29, 2018
libyaml 0.2.1 removed the errorneously written document end marker (`...`) after some scalars in root context (see yaml/libyaml#18). Earlier libyaml releases still write the document end marker and this is hard to fix on Crystal's side. So we just ignore it and adopt the specs accordingly to coincide with the used libyaml version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.