Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libyaml 0.2.1 breaks YAML builder #6283

Closed
straight-shoota opened this issue Jun 28, 2018 · 3 comments · Fixed by #6287
Closed

libyaml 0.2.1 breaks YAML builder #6283

straight-shoota opened this issue Jun 28, 2018 · 3 comments · Fixed by #6287

Comments

@straight-shoota
Copy link
Member

straight-shoota commented Jun 28, 2018

The new release libyaml 0.2.1 seems to change some behaviour which breaks a few of our yaml specs.
An example can be seen on any of the last spec runs on CircleCI OSX since the homebrew formula was updated a few hours ago (e.g. https://circleci.com/gh/crystal-lang/crystal/8409).

It seems like libyaml has removed writing the document end marker (...) and is more consistent now. It was already only added in a few places. So I guess the only thing to do here is to remove the expected \n... from the affected specs.

I'm not sure what exactly causes this as I didn't find any information about this in the libyaml release announcement or the commit history. But I have checked that these specs pass with libyaml 0.1.6 but fail with 0.2.1 on linux as well.
I didn't check 0.1.7 but that had been working in the homebrew formula until recently.

@bcardiff
Copy link
Member

Thanks for investigating. Due to the nature of the change I think that the best thing is to change the assert_built in yaml specs to allow optionally the ...\n suffix.

@asterite
Copy link
Member

I can tackle this

@straight-shoota
Copy link
Member Author

This is caused by yaml/libyaml#18 which removes the erroneously inserted document end marker after a scalar in root context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants