Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Actions workflow #10

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add GitHub Actions workflow #10

wants to merge 3 commits into from

Conversation

am11
Copy link
Contributor

@am11 am11 commented Aug 14, 2020

  • Add GitHub Actions CI script.
  • Run job on push to PR or master branch.
  • Remove interactive (-it) switch from docker run command, to avoid errors like the input device is not a TTY
  • Set test step to continue-on-error; there were four tests failures (raw logs). When they get fixed, we can remove continue-on-error: true line.

Example run: https://github.com/am11/yaml-runtimes/runs/983024052?check_suite_focus=true.

@am11
Copy link
Contributor Author

am11 commented Aug 17, 2020

Apparently the raw logs URL has an expiry date 🤣 luckily we can get the fresh one from:

image

@perlpunk
Copy link
Member

perlpunk commented May 7, 2021

Sorry for not reacting earlier.I have been extremely busy and have to catch up with a lot of stuff.
I'm not sure which errors you got; I just fixed the python and java runtimes in master.

I only wonder how long this workflow will run, and I'm not sure I want to make github run this on every commit.

@am11
Copy link
Contributor Author

am11 commented May 8, 2021

Welcome back. There is no rush for this one at all. It was just a proposal-like pull request. :)

The build logs expired, and I honestly don't even remember what was the error. I have rebased my branch and removed continue-on-error, and as you expected, it did not fail. New logs can be obtained from: https://github.com/am11/yaml-runtimes/actions/runs/821940789

Seems like it takes about 40 to 45 minutes to build all runtimes and run the tests on GitHub Actions.

Currently, it is setup to run on every pull request and push to master branch.

Would you like it changed so it only runs on pull request? I believe it is possible to implement a granular strategy such that in CI, we only build the runtime that has been modified; and only build all runtimes when some common area is touched by the patch. I can explore this option if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants