Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTL Custom Button Types #17

Closed
alexhass opened this issue Jun 24, 2013 · 10 comments
Closed

RTL Custom Button Types #17

alexhass opened this issue Jun 24, 2013 · 10 comments

Comments

@alexhass
Copy link

Some Dingbats have wrong direction. The border is also missing and border radius is on wrong side.

2013-06-24_112549

.ym-form button:before,
.ym-button:before {
  border-radius: .15em .15em 0 0;
}

This may do the trick, but is only tested with these two buttons and may not the correct way. No idea how to solve for other buttons and IE.

  .ym-reply:before,
  .ym-next:before {
    -webkit-transform: rotate(180deg);
    -moz-transform: rotate(180deg);
    transform: rotate(180deg);
  }
  .ym-reply:before {
    content: "\27A6";
  }
@djesse
Copy link
Contributor

djesse commented Jun 24, 2013

I think there's an end of what can be done by adjusting things via CSS in order to provide perfect RTL support. And the dingbats icons are a perfect example. Rotating every icon per default is not a suitable solution - not only because rotating isn't possible in old IEs. Its even a question, if all these icons can be used in the same context in Arabic and/or Hebrew. So ... this is the point were the framework can't deliver the final solution. Borders, of course, can be switched.

@alexhass
Copy link
Author

Well, but IE7 is dead... it's only a limitation of outdated browsers if we rotate. Other icons don't really need rotation. I believe the dingbats are just signs and there should be no problem with them in arabic/hebrew.

@djesse
Copy link
Contributor

djesse commented Jun 25, 2013

No. IE7 is not dead. We might wish it would be but YAML4 still supports IE6 and IE7 and therefore there should be a suitable solution for these browsers too. On the other side, this is a secondary problem that can be "fixed" by the user in their form theme as the buttons are not part of the YAML core.

@alexhass
Copy link
Author

Hast du nicht selbst mal gesagt, dass man manche darstellungsfehler im IE ignorieren kann? Ich denkevwir sollten versuchen es so gut wie möglich zu fixen. Was nicht zu fixen geht und nur 1% der user betrifft sollte nicht so dramatisch sein. Der IE zeigt das icon dann halt in LTR an... Immerhin zeigt er noch etwas an... Besser als nichts.

djesse pushed a commit that referenced this issue Jun 26, 2013
@djesse
Copy link
Contributor

djesse commented Jun 26, 2013

Border radius for custom buttons should now be correct: da8a22b
Won't fix dingbats icons as this should be part of the users adjustments.

@djesse djesse closed this as completed Jun 26, 2013
@alexhass
Copy link
Author

I cannot see a difference. The border between dingbat and button is also missing.

2013-06-27_020633

@djesse djesse reopened this Jun 27, 2013
@djesse
Copy link
Contributor

djesse commented Jun 27, 2013

In which browser do you made this screenshot?

djesse pushed a commit that referenced this issue Jun 27, 2013
- updated RTL demo to make use of forms RTL adjustmenst (gray-theme-rtl.css)
@alexhass
Copy link
Author

Chrome

@djesse djesse closed this as completed Jun 27, 2013
@alexhass
Copy link
Author

Now it works. thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@djesse @alexhass and others