-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RTL Custom Button Types #17
Comments
I think there's an end of what can be done by adjusting things via CSS in order to provide perfect RTL support. And the dingbats icons are a perfect example. Rotating every icon per default is not a suitable solution - not only because rotating isn't possible in old IEs. Its even a question, if all these icons can be used in the same context in Arabic and/or Hebrew. So ... this is the point were the framework can't deliver the final solution. Borders, of course, can be switched. |
Well, but IE7 is dead... it's only a limitation of outdated browsers if we rotate. Other icons don't really need rotation. I believe the dingbats are just signs and there should be no problem with them in arabic/hebrew. |
No. IE7 is not dead. We might wish it would be but YAML4 still supports IE6 and IE7 and therefore there should be a suitable solution for these browsers too. On the other side, this is a secondary problem that can be "fixed" by the user in their form theme as the buttons are not part of the YAML core. |
Hast du nicht selbst mal gesagt, dass man manche darstellungsfehler im IE ignorieren kann? Ich denkevwir sollten versuchen es so gut wie möglich zu fixen. Was nicht zu fixen geht und nur 1% der user betrifft sollte nicht so dramatisch sein. Der IE zeigt das icon dann halt in LTR an... Immerhin zeigt er noch etwas an... Besser als nichts. |
Border radius for custom buttons should now be correct: da8a22b |
In which browser do you made this screenshot? |
- updated RTL demo to make use of forms RTL adjustmenst (gray-theme-rtl.css)
Chrome |
Now it works. thx |
Some Dingbats have wrong direction. The border is also missing and border radius is on wrong side.
This may do the trick, but is only tested with these two buttons and may not the correct way. No idea how to solve for other buttons and IE.
The text was updated successfully, but these errors were encountered: