-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to JAX-RS from raw servlet #82
Conversation
@wyukawa Could you enable Travis CI integration in this repository when you have time? |
@@ -129,6 +130,7 @@ dependencies { | |||
compile 'com.github.wyukawa.elasticsearch.unofficial.jdbc.driver:elasticsearch-jdbc-driver:0.0.9' | |||
compile 'org.jsoup:jsoup:1.11.3' | |||
compile 'mysql:mysql-connector-java:5.1.47' | |||
compile 'com.owlike:genson:1.6' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not familiar with JSON library but is genson necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This library is needed when we set json key name explicitly.
eg @JsonProperty("formattedQuery")
enabled Travis CI integration in this repository like https://github.com/yanagishima/yanagishima/pull/106/checks?check_run_id=253262182 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@ebyhr It works after I commented out the followng line
So I reverted in 5e2f0c2 Could you please check? |
Found the root cause. The default servlet path was overwritten with the above code. Once we swap the order as below, the endpoint will return the expected result. servletContextHandler.addServlet(new ServletHolder(new ServletContainer(new YanagishimaResourceConfig(config))), "/*");
servletContextHandler.addServlet(DefaultServlet.class, "/"); |
No description provided.