Allow empty "static_route" Set #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zuzzas
commented
Sep 8, 2020
|
Hi @zuzzas ! Thank you for PR! Please add record to CHANGELOG. |
damirm
reviewed
Sep 22, 2020
yandex/structures.go
Outdated
| } | ||
|
|
||
| if v, ok := res["next_hop_address"].(string); ok { | ||
| sr.NextHop = &vpc.StaticRoute_NextHopAddress{ | ||
| NextHopAddress: v, | ||
| } | ||
| } else { | ||
| return nil, errors.New("\"static_route\" should have a \"next_hop_address\" field") |
There was a problem hiding this comment.
Use single quotes for field names
zuzzas
force-pushed
the
fix-route-table-optionality
branch
from
850383b
to
e0fe4a6
Compare
Signed-off-by: Andrey Klimentyev <andrey.klimentyev@flant.com>
zuzzas
force-pushed
the
fix-route-table-optionality
branch
from
e0fe4a6
to
6625dc6
Compare
|
@GennadySpb |
damirm
approved these changes
Sep 29, 2020
|
@zuzzas merged! I'm sorry for the delay. |
GennadySpb
added a commit
that referenced
this pull request
Oct 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "static_route" block is marked as optional. Unfortunately, a function that converts a set into a gRPC struct is not aware of that fact.