Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable compile expressions by default #4579

Merged
merged 1 commit into from
Mar 4, 2019

Conversation

alesapin
Copy link
Member

@alesapin alesapin commented Mar 4, 2019

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

For changelog. Remove if this is non-significant change.

Category (leave one):

  • Bug Fix

Short description (up to few sentences):
Disable compile expressions until we get own llvm contrib and can test it with clang and asan.

@alesapin
Copy link
Member Author

alesapin commented Mar 4, 2019

Relevant issues:
#4180
#4561

@alesapin
Copy link
Member Author

alesapin commented Mar 4, 2019

Tried to build with gcc-7 + asan+ compiled_expression_cache_size=5 and reproduce cache overflow. All works fine, expressions are removed, no asserts or segfaults in destructor.
Additionaly we found, that llvm symbol resolution can get into deadlock.

@alexey-milovidov alexey-milovidov merged commit d2d4f4a into master Mar 4, 2019
abyss7 pushed a commit that referenced this pull request Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants