Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compression level detection when network_compression_method in lowercase #4706

Merged
merged 4 commits into from
Mar 18, 2019

Conversation

proller
Copy link
Contributor

@proller proller commented Mar 15, 2019

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

For changelog. Remove if this is non-significant change.

Category (leave one):

  • Bug Fix

Short description (up to few sentences):
Fix compression level detection when network_compression_method in lowercase. Broken in v19.1.0
This usage was broken:

SET network_compression_method = 'zstd';
SET network_zstd_compression_level = 7; 

@alexey-milovidov
Copy link
Member

Approved. But missing details for the changelog: what is the issue, in what version the bug has appeared.

@proller proller merged commit 78e0b1a into ClickHouse:master Mar 18, 2019
@abyss7 abyss7 added the pr-bugfix Pull request with bugfix, not backported by default label Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix Pull request with bugfix, not backported by default
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants