Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw Decimal overflow for Inf and NaN #5282

Merged
merged 3 commits into from
May 16, 2019
Merged

Conversation

4ertus2
Copy link
Contributor

@4ertus2 4ertus2 commented May 15, 2019

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

For changelog. Remove if this is non-significant change.

Category (leave one):

  • Bug Fix

Short description (up to few sentences):
Disallow conversion from float Inf/NaN into Decimals (throw exception).

@4ertus2 4ertus2 merged commit 1e14186 into ClickHouse:master May 16, 2019
@vitlibar vitlibar added the pr-bugfix Pull request with bugfix, not backported by default label May 23, 2019
vitlibar pushed a commit that referenced this pull request May 23, 2019
Throw Decimal overflow for Inf and NaN

(cherry picked from commit 1e14186)
@vitlibar vitlibar added the v19.6 label May 23, 2019
vitlibar pushed a commit that referenced this pull request May 23, 2019
Throw Decimal overflow for Inf and NaN

(cherry picked from commit 1e14186)
@vitlibar vitlibar added the v19.7 label May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix Pull request with bugfix, not backported by default
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants