VALUES list #6209
VALUES list #6209
Conversation
|
|
||
| if (case_sensitiveness == CaseInsensitive | ||
| && !case_insensitive_table_functions.emplace(Poco::toLower(name), creator).second) | ||
| throw Exception("TableFunctionFactory: the case insensitive aggregate function name '" + name + "' is not unique", |
There was a problem hiding this comment.
Not an aggregate function
|
|
||
| for (size_t j = 0; j < value_tuple.size(); ++j) | ||
| { | ||
| Field value = convertFieldToType(value_tuple[j], *sample_block.getByPosition(j).type, value_type_ptr.get()); |
There was a problem hiding this comment.
What if it cannot convertFieldToType?
There was a problem hiding this comment.
What if it cannot
convertFieldToType?
For example : Received exception from server (version 19.13.1): Code: 53. DB::Exception: Received from localhost:9000. DB::Exception: Type mismatch in IN or VALUES section. Expected: String. Got: UInt64.
Do we need to throw more local exception?
Tests will be added soon
|
Single column ValuesList queries doesn't work yet. Trying to implement. UPD: Fixed in |
| namespace DB | ||
| { | ||
|
|
||
| class TableFunctionValues : public ITableFunction |
| namespace DB | ||
| { | ||
|
|
||
| class StorageValues : public ext::shared_ptr_helper<StorageValues>, public IStorage |
|
Latest commits also fix problem #6217, fix is implemented in |
| namespace DB | ||
| { | ||
|
|
||
| void parseColumnsList(const std::string & structure, Block & sample_block, const Context & context); |
There was a problem hiding this comment.
Comment needed.
Better to return Block by value.
There was a problem hiding this comment.
There is comment in later commit
|
Continued in #6255 |
KochetovNicolai
added
pr-improvement
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
For changelog. Remove if this is non-significant change.
Category (leave one):
Short description (up to few sentences):
#5984 implemented
#6217 Fixed