Input ORC format #6454
Merged
Input ORC format #6454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
proller
reviewed
Aug 12, 2019
contrib/arrow-cmake/CMakeLists.txt
Outdated
| include_directories(SYSTEM ${ORC_INCLUDE_DIR}) | ||
| include_directories(SYSTEM ${ORC_SOURCE_SRC_DIR}) | ||
| include_directories(SYSTEM ${ORC_SOURCE_WRAP_DIR}) | ||
| include_directories(SYSTEM ${GOOGLE_PROTIBUF_DIR}) |
| if (!in.eof()) | ||
| { | ||
| if (row_group_current < row_group_total) | ||
| throw Exception{"Got new data, but data from previous chunks not readed " + std::to_string(row_group_current) + "/" + std::to_string(row_group_total), ErrorCodes::CANNOT_READ_ALL_DATA}; |
There was a problem hiding this comment.
not readed -> was not read
|
Is it possible to generate protobuf on the fly? (auto-generated file does not look good). |
proller
reviewed
Aug 12, 2019
contrib/CMakeLists.txt
Outdated
| @@ -10,6 +10,13 @@ endif () | |||
|
|
|||
| set_property(DIRECTORY PROPERTY EXCLUDE_FROM_ALL 1) | |||
|
|
|||
| #===== add orc subdir | |||
There was a problem hiding this comment.
if (USE_INTERNAL_ORC_LIBRARY) ...
|
Is it possible to generate protobuf on the fly? - Alexey, what file are you talking about? |
|
orc_proto.pb.cc ? |
|
now orc_proto building with proto-command (I added command in arrow-cmake cmakeFile) |
added 4 commits
August 21, 2019 19:39
…QM-34 # Conflicts: # dbms/src/Processors/Formats/Impl/ParquetBlockInputFormat.cpp
|
common part for parquetBlockInput and orcBlockInput was migrated to ArrowColumnToCHColumn class |
Merged
abyss7
reviewed
Sep 4, 2019
| @@ -0,0 +1,8 @@ | |||
| ##TODO replace hardcode to find procedure | |||
|
|
|||
There was a problem hiding this comment.
@akonyaev90 when are you going to implement the proper build logic for ORC contrib?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Category (leave one):
Short description (up to few sentences):
Add input ORC format
...
For read data in ORC format.
Made similar to parquet.
The file we are reading should fit in memory.
...
#4903