Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor limiters #12

Closed
direvius opened this issue Dec 4, 2015 · 0 comments · Fixed by #53
Closed

Refactor limiters #12

direvius opened this issue Dec 4, 2015 · 0 comments · Fixed by #53
Milestone

Comments

@direvius
Copy link
Collaborator

direvius commented Dec 4, 2015

  • use Timer and Timer.Reset instead of After
  • implement Periodic limiter using Timer instead of Ticker
  • don't use channels for limiters composition

Basic idea: generate timestamps with a function and use them to drive the Timer.

skipor added a commit to skipor/pandora that referenced this issue Jul 11, 2017
skipor added a commit to skipor/pandora that referenced this issue Jul 11, 2017
skipor added a commit to skipor/pandora that referenced this issue Jul 11, 2017
@direvius direvius modified the milestone: Release 0.2 Jul 11, 2017
skipor added a commit to skipor/pandora that referenced this issue Jul 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant