Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra ammo consumed at instance schedule finish #55

Closed
skipor opened this issue Jul 14, 2017 · 1 comment
Closed

Extra ammo consumed at instance schedule finish #55

skipor opened this issue Jul 14, 2017 · 1 comment

Comments

@skipor
Copy link
Contributor

skipor commented Jul 14, 2017

Instance takes ammo before schedule token take, that allows be ready, when take next schedule token, and operate close to schedule.
But in case of individual schedules, extra ammo will be taken.

Propose add IsFinished() bool schedule method, that allows check is schedule finished before taking ammo.

In such case, in case of shared schedule, some extra ammos can be consumed anyway at schedule finish, but that is minor problem - that will happen once after shooting finish.

@skipor
Copy link
Contributor Author

skipor commented Jul 24, 2017

Maybe better will be add EventsLeft() (n int) where
0 - finished
n > 0 - exactly n
n < 0 - don't know, but not finished yet (unlimited, not implemented, etc.)

Such info will be useful to log in every second status.

Also FinishTime() time.Time may be useful for log too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant