Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace %env magic with os.environ #284

Merged
merged 1 commit into from
Sep 5, 2019

Conversation

dniku
Copy link
Collaborator

@dniku dniku commented Sep 5, 2019

This ensures that future attempts to autoformat the code won't break it again.

Complementary to #283.

This ensures that future attempts to autoformat the code won't break it again.
@dniku dniku added the coursera label Sep 5, 2019
@dniku dniku self-assigned this Sep 5, 2019
@review-notebook-app
Copy link

Check out this pull request on ReviewNB: https://app.reviewnb.com/yandexdataschool/Practical_RL/pull/284

You'll be able to see notebook diffs and discuss changes. Powered by ReviewNB.

@yhn112
Copy link
Collaborator

yhn112 commented Sep 5, 2019

May be we also want to replace !bash ../xvfb start\n", with subprocess.call?

@dniku
Copy link
Collaborator Author

dniku commented Sep 5, 2019

The purpose of this PR is to fix breakage due to : 1 instead of :1. We also have #274 for a bigger refactoring.

Copy link
Collaborator

@yhn112 yhn112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't have worked? Now should work? LGTM

@dniku dniku merged commit 5cbd073 into coursera Sep 5, 2019
@dniku dniku deleted the coursera-replace-env-magic-with-os-environ branch September 5, 2019 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants