-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support array_value attribute type #82
Comments
Do you mean add two method to get http header attributes for span, just like golang sdk: |
Those helper functions would be useful too! Looking into the ppentelemetry/attribute.lua it's missing the |
I will try to implement this. |
yangxikun
pushed a commit
that referenced
this issue
Sep 10, 2023
yangxikun
added a commit
that referenced
this issue
Sep 11, 2023
feat: support array_value attribute type, closes #82
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Would be helpful for sending the the
header.(request|response).header.<key>
for following the http conventions: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/http.md#http-request-and-response-headersHTTP request and response headers
http.request.header.<key>
<key>
being the normalized HTTP Header name (lowercase, with-
characters replaced by_
), the value being the header values. [1] [2]http.request.header.content_type=["application/json"]
;http.request.header.x_forwarded_for=["1.2.3.4", "1.2.3.5"]
http.response.header.<key>
<key>
being the normalized HTTP Header name (lowercase, with-
characters replaced by_
), the value being the header values. [1] [2]http.response.header.content_type=["application/json"]
;http.response.header.my_custom_header=["abc", "def"]
P.S. thank you for all your work so far!
The text was updated successfully, but these errors were encountered: