Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support array_value attribute type #82

Closed
fularac opened this issue Aug 24, 2023 · 3 comments
Closed

Support array_value attribute type #82

fularac opened this issue Aug 24, 2023 · 3 comments

Comments

@fularac
Copy link

fularac commented Aug 24, 2023

Would be helpful for sending the the header.(request|response).header.<key> for following the http conventions: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/http.md#http-request-and-response-headers

HTTP request and response headers

Attribute Type Description Examples Requirement Level
http.request.header.<key> string[] HTTP request headers, <key> being the normalized HTTP Header name (lowercase, with - characters replaced by _), the value being the header values. [1] [2] http.request.header.content_type=["application/json"]; http.request.header.x_forwarded_for=["1.2.3.4", "1.2.3.5"] Opt-In
http.response.header.<key> string[] HTTP response headers, <key> being the normalized HTTP Header name (lowercase, with - characters replaced by _), the value being the header values. [1] [2] http.response.header.content_type=["application/json"]; http.response.header.my_custom_header=["abc", "def"] Opt-In

P.S. thank you for all your work so far!

@fularac
Copy link
Author

fularac commented Aug 25, 2023

Those helper functions would be useful too!

Looking into the ppentelemetry/attribute.lua it's missing the <type>Slice versions as found in https://github.com/open-telemetry/opentelemetry-go/blob/69611bd01a355466f324cca84068f54e6e388654/attribute/value.go#L40-L59

@yangxikun
Copy link
Owner

I will try to implement this.

yangxikun added a commit that referenced this issue Sep 11, 2023
feat: support array_value attribute type, closes #82
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants