Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support array_value attribute type, closes #82 #84

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

yangxikun
Copy link
Owner

No description provided.

@yangxikun yangxikun merged commit 6e44fe8 into main Sep 11, 2023
4 checks passed
@plantfansam
Copy link
Contributor

semantic_conventions/trace/http.lua is automatically generated by https://github.com/yangxikun/opentelemetry-lua/blob/main/Makefile#L36, so we should move the functions added there to a different file.

@yangxikun
Copy link
Owner Author

Ok, I will refactor this pr.

@yangxikun
Copy link
Owner Author

yangxikun commented Sep 25, 2023

semantic_conventions/trace/http.lua is automatically generated by https://github.com/yangxikun/opentelemetry-lua/blob/main/Makefile#L36, so we should move the functions added there to a different file.

The specification had changed file format from yaml to markdown: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/http.md
I think we should maintain semantic_conventions manually now. @plantfansam

@plantfansam
Copy link
Contributor

I think they've just moved to a new repository - https://github.com/open-telemetry/semantic-conventions/blob/main/model/trace/http.yaml. I can work on fixing the script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants