Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Ignoring pure components without props and context usage #2238

Merged
merged 1 commit into from Apr 12, 2019

Conversation

Projects
None yet
2 participants
@pawelnvk
Copy link
Contributor

pawelnvk commented Apr 12, 2019

Pure components without props are still valid, since they prevent rerendering of component even if parent component is being rerendered.

Fixes #2186.

@ljharb

ljharb approved these changes Apr 12, 2019

@ljharb ljharb merged commit f0c0b4d into yannickcr:master Apr 12, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 97.5%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.