Changes needed in order not to get a null exception when trying to display the images within a jar file. #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…splay the images within a jar file.
panossot
added a commit
to panossot/jam-metrics
that referenced
this pull request
May 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The github comparison is not accurate. The change is the following for every image access :
Line(s) : new ImageIcon(PlotPanel.class.getResource("icons/center.png"))
is replaced with :
new ImageIcon(ImageIO.read(PlotPanel.class.getResourceAsStream("icons/center.png")))
plus there are a couple of additional try-catch blocks.