Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify toast messages. #339

Closed
ThomasLeigh opened this issue Oct 2, 2019 · 9 comments
Closed

Unify toast messages. #339

ThomasLeigh opened this issue Oct 2, 2019 · 9 comments

Comments

@ThomasLeigh
Copy link
Collaborator

Screenshots below illustrate examples of two HNR toast messages which look differently. One is vividly rounded and its text has padding applied. The other seems to be without rounded corners and its text seems not to have padding applied.

Could we have toast messages unified to one form? I would prefer the rounded one and padding included (exactly as in the example below). It would be also great to have them all displayed in the same place (I would recommend the centered version - as in the brightness example).

Screenshot_20190929-175137
Screenshot_20190929-175145

Besides, I think that it would be nice to have all toast messages' text centered. But the most important thing is to have them unified, i.e. all HNR toast messages looking the same way.

@yanus171
Copy link
Owner

yanus171 commented Oct 3, 2019

Brightness is not the toast message. It's the element of the window gui. It would be hard to guess the toast style in every phone

@ThomasLeigh
Copy link
Collaborator Author

Ok, and about toast text being centered - would You mind? I mean both toasts text and brightness "toast" - or just toasts... :) (I like cheese toasts much - and You :) ).

@yanus171
Copy link
Owner

yanus171 commented Oct 4, 2019

Brightness label is not the toast and it should not be layout accordingly. Toast is a system message that I can customize programmatically

@ThomasLeigh
Copy link
Collaborator Author

Brightness label is not the toast and it should not be layout accordingly.

Could it look nicer, like (for example) this brightness indicator from MoonReader?

Screenshot (Oct 4, 2019 20_16_06)

Toast is a system message that I can customize programmatically

Would You mind centering their text?

@ThomasLeigh
Copy link
Collaborator Author

@yanus171 I noticed that under Android 9/MIUI 11 text within HNR toasts is already centered. I don’t know if this is thanks to MIUI, Android - or maybe You've centered it?

@yanus171
Copy link
Owner

yanus171 commented Nov 30, 2019 via email

@ThomasLeigh
Copy link
Collaborator Author

And I’ll tell You that: centered toasts look

gorgeous

*.* I’d like other people to have this experience as well!

@yanus171
Copy link
Owner

yanus171 commented Dec 1, 2019

Show me a screenshot please

@ThomasLeigh
Copy link
Collaborator Author

Here You are:

Screenshot_2019-12-01-22-10-11-354_ru yanus171 feedexfork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants