Add host:port msg if we failed to initialize #303
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @yaooqinn |
yaooqinn
reviewed
Jan 26, 2021
| @@ -99,7 +99,8 @@ class FrontendService private (name: String, be: BackendService, oomHook: Runnab | |||
| s" [$minThreads, $maxThreads] worker threads") | |||
| } catch { | |||
| case e: Throwable => | |||
| throw new KyuubiException("Failed to initialize frontend service", e) | |||
| throw new KyuubiException("Failed to initialize frontend service, " + | |||
| s"please check this host:port $serverAddr:$portNum is available.", e) | |||
There was a problem hiding this comment.
this looks like, we into a particular exception inevitable
There was a problem hiding this comment.
How about just Failed to initialize frontend service on host:port?
yaooqinn
approved these changes
Jan 26, 2021
yaooqinn
pushed a commit
that referenced
this pull request
Jan 26, 2021
 [](https://github.com/yaooqinn/kyuubi/pull/303) [❨?❩](https://pullrequestbadge.com/?utm_medium=github&utm_source=yaooqinn&utm_campaign=badge_info)<!-- PR-BADGE: PLEASE DO NOT REMOVE THIS COMMENT --> <!-- Thanks for sending a pull request! Here are some tips for you: 1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html --> <!-- replace ${issue ID} with the actual issue id --> Fixes #303 <!-- Please clarify why the changes are needed. For instance, 1. If you add a feature, you can talk about the user case of it. 2. If you fix a bug, you can clarify why it is a bug. --> Before this PR, if we start Kyuubi with an already used port, we will get this error msg. It's better to print host:port which we bind. ``` Exception in thread "main" org.apache.kyuubi.KyuubiException: Failed to initialize frontend service at org.apache.kyuubi.service.FrontendService.initialize(FrontendService.scala:102) at org.apache.kyuubi.service.CompositeService.$anonfun$initialize$1(CompositeService.scala:40) at org.apache.kyuubi.service.CompositeService.$anonfun$initialize$1$adapted(CompositeService.scala:40) at scala.collection.mutable.ResizableArray.foreach(ResizableArray.scala:62) at scala.collection.mutable.ResizableArray.foreach$(ResizableArray.scala:55) at scala.collection.mutable.ArrayBuffer.foreach(ArrayBuffer.scala:49) at org.apache.kyuubi.service.CompositeService.initialize(CompositeService.scala:40) at org.apache.kyuubi.service.Serverable.initialize(Serverable.scala:37) at org.apache.kyuubi.server.KyuubiServer.initialize(KyuubiServer.scala:88) at org.apache.kyuubi.server.KyuubiServer$.startServer(KyuubiServer.scala:45) at org.apache.kyuubi.server.KyuubiServer$.main(KyuubiServer.scala:74) at org.apache.kyuubi.server.KyuubiServer.main(KyuubiServer.scala) Caused by: java.net.BindException: Address already in use at java.net.PlainSocketImpl.socketBind(Native Method) at java.net.AbstractPlainSocketImpl.bind(AbstractPlainSocketImpl.java:387) at java.net.ServerSocket.bind(ServerSocket.java:375) at java.net.ServerSocket.<init>(ServerSocket.java:237) at org.apache.kyuubi.service.FrontendService.initialize(FrontendService.scala:77) ... 11 more ``` - Add some test cases that check the changes thoroughly including negative and positive cases if possible - Add screenshots for manual tests if appropriate - [Run test](https://kyuubi.readthedocs.io/en/latest/tools/testing.html#running-tests) locally before make a pull request Squashed commit of the following: commit c3f5ffa Author: ulysses-you <ulyssesyou18@gmail.com> Date: Tue Jan 26 18:23:40 2021 +0800 fix commit 42d333d Author: ulysses-you <ulyssesyou18@gmail.com> Date: Tue Jan 26 14:44:35 2021 +0800 err msg
|
thanks, merged to master for v1.1.0 and branch 1.0 for v1.0.3 |
|
please make a followup to fix test |
|
my bad.. missed the test Created #305 |
yaooqinn
pushed a commit
that referenced
this pull request
Jan 26, 2021
yaooqinn
pushed a commit
that referenced
this pull request
Jan 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please add issue ID here?
Fixes #303
Why are the changes needed?
Before this PR, if we start Kyuubi with an already used port, we will get this error msg.
It's better to print host:port which we bind.
Test Plan: