Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider renaming git-review to git-lab #13

Closed
dancysoft opened this issue Aug 17, 2023 · 0 comments · Fixed by #15
Closed

Consider renaming git-review to git-lab #13

dancysoft opened this issue Aug 17, 2023 · 0 comments · Fixed by #15

Comments

@dancysoft
Copy link
Collaborator

Please consider renaming git-review to git-lab. Reasons:

  1. To avoid a collision with the standard git-revew plugin, especially in the case where people need to deal with both Gerrit and GitLab (such as during Wikimedia Foundation's transition from Gerrit to GitLab).
  2. Running git lab would be cool.
dancysoft pushed a commit that referenced this issue Aug 17, 2023
Rename git-review to git-lab
48f6f26 
so that invocation of the plugin is "git lab".

Updated README.md to reflect the name change.

Closes: #13
Change-Id: I9a19b4585cb035234a5df10d57bf8e4f8aa247a7
@dancysoft dancysoft mentioned this issue Aug 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename git-review to git-lab yaoyuannnn/gerritlab
1 participant
@dancysoft