Skip to content

Commit

Permalink
update README.md Custom Modals section
Browse files Browse the repository at this point in the history
A `full-screen-modal` component that subclasses `modal-dialog` will not display correctly if it has a template file.
I think specifying it here, would reduce confusion for people using cli generator commands.
  • Loading branch information
hakilebara committed Aug 17, 2018
1 parent 5fab891 commit 4e234b4
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,8 @@ export default ModalDialog.extend({
});
```

This can then be used like so:
By subclassing `modal-dialog` your component will use the default modal dialog template. Therefore, you do not need to create a `app/templates/components/full-screen-modal.hbs` file.
Your component can then be used like so:

```htmlbars
{{#full-screen-modal}}
Expand Down

0 comments on commit 4e234b4

Please sign in to comment.