Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make -initWithReachabilityRef: retain the ref argument, fixing a Clang analyzer warning. #414

Merged
merged 1 commit into from Jul 18, 2017
Merged

Make -initWithReachabilityRef: retain the ref argument, fixing a Clang analyzer warning. #414

merged 1 commit into from Jul 18, 2017

Commits on Jul 10, 2017

  1. -initWithReachabilityRef: now retains the ref argument. 

    Without this Clang shows an analyzer warning that after calling -initWithReachabilityRef: the ref should be released. Because -initWithReachabilityRef: doesn’t retain the argument, this would result in a dangling pointer.

Warning: This change fixes the issue in YapDatabase internally, but it introduces a memory leak for consumers that are currently using -initWithReachabilityRef without releasing the ref.
    Fabian Kreiser committed Jul 10, 2017
    Copy the full SHA
    ffd8d69 View commit details
    Browse the repository at this point in the history