Fix breaking change note in CHANGELOG.md #1166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlier in the changelog for 12.0.0 it mentions that Node 6 was _added_ to the testing matrix, then under breaking changes it says the opposite. I _believe_ that the breaking change section intended to say that Node 4 was dropped (it is EOL after all) not Node 6.
|
@rwjblue great catch, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier in the changelog for 12.0.0 it mentions that Node 6 was added to the testing matrix, then under breaking changes it says the opposite. I believe that the breaking change section intended to say that Node 4 was dropped (it is EOL after all) not Node 6.
This will also need to be updated in the GitHub release (which is used by tolls like greenkeeper / renovate / dependabot/ etc).