Skip to content

Commit

Permalink
Merge remote-tracking branch 'origin/auto-format-pyproject' into vali…
Browse files Browse the repository at this point in the history
…date-extras-workflow

* origin/auto-format-pyproject: (27 commits)
  added new hook
  format using new hook
  added new hook
  [DOC] fixing docstring example for `FhPlexForecaster` (sktime#4931)
  Revert "[MNT] instant release action" (sktime#5421)
  [MNT] instant release action (sktime#5419)
  Release 0.24.0 (sktime#5403)
  🚀 python 3.12 🚀  (sktime#5345)
  Revert "[MNT] instant release action" (sktime#5415)
  [MNT] 0.24.0 deprecations and change actions (sktime#5404)
  [MNT] [Dependabot](deps-dev): Update holidays requirement from <0.34,>=0.29 to >=0.29,<0.35 (sktime#5342)
  [MNT] Migrate from `pykalman` to `pykalman-bardo` (sktime#5277)
  [MNT] [Dependabot](deps-dev): Update skpro requirement from <2.1.0,>=2.0.0 to >=2.0.0,<2.2.0 (sktime#5396)
  [MNT] [Dependabot](deps-dev): Update numba requirement from <0.58,>=0.53 to >=0.53,<0.59 (sktime#5319)
  [MNT] update numba requirement from <0.58,>=0.53 to >=0.53,<0.59"" (sktime#5299)
  [MNT] instant release action (sktime#5265)
  Release 0.23.1 - omitted changelog commit (sktime#5413)
  Release 0.23.1 (sktime#5402)
  [ENH] Refactor of `DateTimeFeatures` tests to `pytest` fixtures (sktime#5397)
  [ENH] remove legacy except in `TestAllEstimators` for `predict_proba` (sktime#5386)
  ...
  • Loading branch information
yarnabrina committed Oct 14, 2023
2 parents c31a6fe + 4204ee6 commit f353053
Show file tree
Hide file tree
Showing 60 changed files with 1,155 additions and 436 deletions.
18 changes: 18 additions & 0 deletions .all-contributorsrc
Original file line number Diff line number Diff line change
Expand Up @@ -2414,6 +2414,24 @@
"contributions": [
"doc"
]
},
{
"login": "adamkells",
"name": "Adam Kells",
"avatar_url": "https://avatars.githubusercontent.com/u/19709277?v=4",
"profile": "https://github.com/adamkells",
"contributions": [
"test"
]
}
{
"login": "xansh",
"name": "Ansh Kumar",
"avatar_url": "https://avatars.githubusercontent.com/u/65403652?s=400&u=a45b5dcca057cfaef737d5fab99850aca6da1607&v=4",
"profile": "https://github.com/xansh",
"contributions": [
"doc"
]
},
]
}
17 changes: 11 additions & 6 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
<!--
Thanks for contributing a pull request! Please ensure you have taken a look
at our contribution guide: https://github.com/sktime/sktime/blob/main/CONTRIBUTING.md
Welcome to sktime, and thanks for contributing!
Please have a look at our contribution guide:
https://www.sktime.net/en/latest/get_involved/contributing.html
-->

#### Reference Issues/PRs
Expand All @@ -9,7 +10,8 @@ Example: Fixes #1234. See also #3456.
Please use keywords (e.g., Fixes) to create link to the issues or pull requests
you resolved, so that they will automatically be closed when your pull request
is merged. See https://github.com/blog/1506-closing-issues-via-pull-requests
is merged. See https://github.com/blog/1506-closing-issues-via-pull-requests.
If no issue exists, you can open one here: https://github.com/sktime/sktime/issues
-->


Expand All @@ -21,7 +23,10 @@ A clear and concise description of what you have implemented.
#### Does your contribution introduce a new dependency? If yes, which one?

<!--
If your contribution does add a new hard dependency, we may suggest to initially develop your contribution in a separate companion package in https://github.com/sktime/ to keep external dependencies of the core sktime package to a minimum.
Only relevant if you changed pyproject.toml.
We try to minimize dependencies in the core dependency set. There
are also further specific instructions to follow for soft dependencies.
See here for handling dependencies in sktime: https://www.sktime.net/en/latest/developer_guide/dependencies.html
-->

#### What should a reviewer concentrate their feedback on?
Expand All @@ -35,7 +40,8 @@ If your contribution does add a new hard dependency, we may suggest to initially

#### Any other comments?
<!--
Please be aware that we are a loose team of volunteers so patience is necessary; assistance handling other issues is very welcome. We value all user contributions, no matter how minor they are. If we are slow to review, either the pull request needs some benchmarking, tinkering, convincing, etc. or more likely the reviewers are simply busy. In either case, we ask for your understanding during the review process.
We value all user contributions, no matter how small or complex they are. If you have any questions, feel free to post
in the dev-chat channel on the sktime discord https://discord.com/invite/54ACzaFsn7. If we are slow to review (>3 working days), likewise feel free to ping us on discord. Thank you for your understanding during the review process.
-->

#### PR checklist
Expand All @@ -57,7 +63,6 @@ Please go through the checklist below. Please feel free to remove points if they
- [ ] If the estimator relies on a soft dependency, I've set the `python_dependencies` tag and ensured
dependency isolation, see the [estimator dependencies guide](https://www.sktime.net/en/latest/developer_guide/dependencies.html#adding-a-soft-dependency).


<!--
Thanks for contributing!
-->
4 changes: 2 additions & 2 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ jobs:
strategy:
fail-fast: false # to not fail all combinations if just one fail
matrix:
python-version: ['3.8', '3.9', '3.10', '3.11']
python-version: ['3.8', '3.9', '3.10', '3.11', '3.12']
os: [ubuntu-latest, macos-latest, windows-latest]
runs-on: ${{ matrix.os }}
steps:
Expand Down Expand Up @@ -213,7 +213,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: ['3.8', '3.9', '3.10', '3.11']
python-version: ['3.8', '3.9', '3.10', '3.11', '3.12']
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
Expand Down
7 changes: 6 additions & 1 deletion .github/workflows/wheels.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:
fail-fast: false # to not fail all combinations if just one fail
matrix:
os: [ubuntu-latest, macos-latest]
python-version: ['3.8', '3.9', '3.10', '3.11']
python-version: ['3.8', '3.9', '3.10', '3.11', '3.12']

steps:
- uses: actions/checkout@v4
Expand Down Expand Up @@ -86,6 +86,11 @@ jobs:
python-version: '3.11'
bitness: 64
platform_id: win_amd64
- os: windows-latest
python: 312
python-version: '3.12'
bitness: 64
platform_id: win_amd64

steps:
- uses: actions/checkout@v4
Expand Down
10 changes: 10 additions & 0 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -76,3 +76,13 @@ repos:
hooks:
- id: shellcheck
name: shellcheck

- repo: https://github.com/tox-dev/pyproject-fmt
rev: 1.2.0
hooks:
- id: pyproject-fmt

- repo: https://github.com/abravalheri/validate-pyproject
rev: v0.15
hooks:
- id: validate-pyproject
Loading

0 comments on commit f353053

Please sign in to comment.