Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compat): update patch for typescript@4.8.4 and typescript@4.9.1-beta #4903

Merged
merged 2 commits into from Sep 28, 2022

Conversation

merceyz
Copy link
Member

@merceyz merceyz commented Sep 25, 2022

What's the problem this PR addresses?

The PnP compatibility patch for TypeScript doesn't apply to typescript@4.8.4 and typescript@4.9.1-beta.

Fixes #4915

How did you fix it?

Rebased microsoft/TypeScript#35206 onto the 4.8.4 and 4.9.1-beta release.

Checklist

  • I have read the Contributing Guide.
  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@merceyz merceyz changed the title fix(compat): update patch for typescript@4.9.1-beta fix(compat): update patch for typescript@4.8.4 and typescript@4.9.1-beta Sep 27, 2022
@arcanis arcanis merged commit 58cb78f into master Sep 28, 2022
@arcanis arcanis deleted the merceyz/fix/typescript-49-beta branch September 28, 2022 14:39
merceyz added a commit that referenced this pull request Sep 28, 2022
…1-beta` (#4903)

* fix(compat): update patch for `typescript@4.9.1-beta`

* fix(compat): update patch for `typescript@4.8.4`
@simPod
Copy link

simPod commented Sep 29, 2022

Can we expect a yarn 3.x patch release soon?

@arcanis
Copy link
Member

arcanis commented Sep 29, 2022

Unlikely until next week, I'm traveling.

@adalinesimonian
Copy link
Contributor

having some issues still with workspaces when downgrading to 4.8.3 while waiting for this patch (see vuejs/language-tools#918 (comment). single repos started working, but monorepos still are failing resolution on my end. is this patch likely to fix this? happy to try it out if there's a straightforward way to do so.

@merceyz
Copy link
Member Author

merceyz commented Sep 30, 2022

That seems unrelated to what this PR was fixing, please open a separate issue.

ethanwu10 added a commit to ocf/ocfstatic that referenced this pull request Oct 3, 2022
Typescript 4.8.4 is held back pending release of yarnpkg/berry#4903
@merceyz
Copy link
Member Author

merceyz commented Oct 5, 2022

Can we expect a yarn 3.x patch release soon?

The fix is now available in v3.2.4

yarn set version berry

JengYoung added a commit to JengYoung/javascript-utils that referenced this pull request Oct 14, 2022
결국 타입스크립트와 베리 버전의 호환성 문제였다. 내 8시간...이 이렇게 허무하게 흘러갔다.  yarnpkg/berry#4903
@agrobbin
Copy link

@merceyz @arcanis is this something that will need to happen again now that Typescript 4.9 has gone stable (as 4.9.3)?

@merceyz
Copy link
Member Author

merceyz commented Nov 16, 2022

It happened already in #5020 and was released earlier today https://github.com/yarnpkg/berry/releases/tag/%40yarnpkg%2Fcli%2F3.3.0

@agrobbin
Copy link

Thanks for the quick response @merceyz! Looks like I'm a few hours behind the times. 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TS 4.8.4 not working
5 participants