Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves peer dependency errors #1362

Merged
merged 2 commits into from
May 15, 2020
Merged

Improves peer dependency errors #1362

merged 2 commits into from
May 15, 2020

Conversation

arcanis
Copy link
Member

@arcanis arcanis commented May 15, 2020

What's the problem this PR addresses?

It's currently difficult to fix peer dependency errors, because Yarn doesn't say who's the package that's not providing the peer dependency. As a result, users often have to use yarn why to better understand the problem, which isn't a great user experience.

How did you fix it?

Yarn will now obtain the list of packages that depend on the one making the require call, and detect which ones of them don't properly list the dependency. It'll then report those packages in the error message under the "Ancestor breaking the chain" moniker.

@arcanis arcanis merged commit 3c25698 into master May 15, 2020
@arcanis arcanis deleted the mael/peer-errors-details branch May 15, 2020 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant