fix(core): normalize relative filepaths in Manifest #2058

merceyz · 2020-10-27T21:56:00Z

What's the problem this PR addresses?

Packages can be published using backslash in their fields which breaks on non-Windows systems.

Fixes #2054

How did you fix it?

Replace backslash with slash in fields that can contain relative filepaths

Checklist

I have read the Contributing Guide.
I have set the packages that need to be released for my changes to be effective.
I will check that all automated PR checks pass before the PR gets reviewed.

andreialecu · 2020-10-27T22:09:09Z

Looks like a normalizePath(path) helper function might be useful somewhere in the core.

packages/yarnpkg-core/sources/Manifest.ts

merceyz requested a review from arcanis as a code owner October 27, 2020 21:56

merceyz mentioned this pull request Oct 27, 2020

[Bug] Path Resolution Failed (ts-node-dev) #2054

Closed

arcanis reviewed Oct 28, 2020

View reviewed changes

packages/yarnpkg-core/sources/Manifest.ts Outdated Show resolved Hide resolved

paul-soporan reviewed Oct 29, 2020

View reviewed changes

packages/yarnpkg-core/sources/Manifest.ts Outdated Show resolved Hide resolved

merceyz added 5 commits October 30, 2020 16:48

fix(core): normalize filepaths in manifest

e2619a2

refactor: move to a helper

df71732

fix(core): normalize publishConfig.browser

df3797b

chore: lint

f877cbf

refactor: move normalize out of manifest

9b0f77f

merceyz force-pushed the merceyz/manifest-normalize branch from f8804d5 to 9b0f77f Compare October 30, 2020 15:48

paul-soporan approved these changes Oct 30, 2020

View reviewed changes

arcanis merged commit 6ca8b6f into master Oct 30, 2020

arcanis deleted the merceyz/manifest-normalize branch October 30, 2020 18:01

Provide feedback