Fixes findPackageLocator on parent directories #2061
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
The
findPackageLocator
function was incorrectly handling the case where the path in parameter was the parent folder of the current project. When that happened, the..
string was turned into./../
, which got detected as part of the root workspace by the function (due to the path now being prefixed by./
).How did you fix it?
Tweaked the RegExp to make sure that
..
was turned into../
, but without the leading./
.Checklist