Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(node-modules): cache install state #2576

Merged
merged 2 commits into from
Mar 8, 2021
Merged

Conversation

merceyz
Copy link
Member

@merceyz merceyz commented Mar 7, 2021

What's the problem this PR addresses?

#2564 but for the node-modules linker

ref #2575

How did you fix it?

Cache the install state

Results

Running hyperfine -w 5 'yarn jest --version' on https://github.com/jest-community/eslint-plugin-jest (cc @SimenB)

 Benchmark #1: yarn jest --version
-  Time (mean ± σ):      2.645 s ±  0.026 s    [User: 1.227 s, System: 0.288 s]
+  Time (mean ± σ):      2.347 s ±  0.020 s    [User: 930.2 ms, System: 235.9 ms]
-  Range (min … max):    2.624 s …  2.702 s    10 runs
+  Range (min … max):    2.320 s …  2.386 s    10 runs

(Ran on WSL2 over the network mounted C drive)

Checklist

  • I have read the Contributing Guide.
  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@arcanis arcanis merged commit efd890a into master Mar 8, 2021
@arcanis arcanis deleted the merceyz/faster-run-nm branch March 8, 2021 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants