Improves yarn run performances #2564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just tried it on my work repository: time to run a dummy script went from 4.5s down to 2s. Still some area of improvement, but a clear win. |
|
Tested on a work repository as well, but from a plugin consuming the API to find the location of packages (which run does as well but that's not the point), finding the location of 58 dependencies went from 3745ms to ~200ms 👍 🎉 |
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
We were always re-requiring the PnP API anew, even inside tight loops.
Closes #2560
How did you fix it?
The PnP API is now cached. This should be fine, considering that users will just have to create a new linker (from the configuration class) to clear all such caches.
Checklist