perf(plugin-pnp): only reload pnpapi when it changes #2942
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
The cache introduced in #2564 only survives as long as the linker instance does, this means it doesn't affect running multiple scripts (i.e. postinstalls) since new linkers are created every time.
How did you fix it?
A
dynamicRequireFresh
(naming suggestions welcome) function that caches the module globally and only reloads it if the file changedResult
Tested on the gatsby benchmark
berry/scripts/bench-run.sh
Lines 74 to 76 in 5411f76
Checklist