Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove outdated workflow #4960

Merged
merged 5 commits into from
Oct 24, 2022

Conversation

jj811208
Copy link
Contributor

@jj811208 jj811208 commented Oct 13, 2022

What's the problem this PR addresses?

related #4954

remove outdated workflow

e2e-snowpack-workflow

snowpack is no longer actively maintained. https://www.snowpack.dev/

Update (April 20, 2022): Snowpack is no longer actively maintained and is not recommended for new projects.

Check out [Vite](https://vitejs.dev/) for a well-maintained Snowpack alternative.
See also: [esbuild](https://esbuild.github.io/), [parcel](https://parceljs.org/)

e2e-vue-cli-workflow

vue cli is in Maintenance Mode(it mean no new features will be added, only serious and common-case bugs will be fixed), and vue official is recommended to use create-vue (vite) to build vue projects. https://cli.vuejs.org/

Vue CLI is in Maintenance Mode!

For new projects, please use [create-vue](https://github.com/vuejs/create-vue) to scaffold [Vite](https://vitejs.dev/)-based projects. Also refer to the [Vue 3 Tooling Guide](https://vuejs.org/guide/scaling-up/tooling.html) for the latest recommendations.

package-workflow

This is a workflow that is no longer used

see: #4954 (comment)

...

How did you fix it?

  1. delete e2e-snowpack-workflow
  2. delete e2e-vue-cli-workflow
  3. revert Build Debian package #379

...

Checklist

  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@jj811208 jj811208 marked this pull request as ready for review October 13, 2022 13:19
@merceyz merceyz self-requested a review October 13, 2022 13:54
@RDIL
Copy link
Member

RDIL commented Oct 13, 2022

Vue-CLI also had a case-study: #964

@RDIL
Copy link
Member

RDIL commented Oct 13, 2022

@Daniel15 is any of the deb packaging code used in your build infrastructure in this repo? Just want to make sure the removal doesn't break anything.

@Daniel15
Copy link
Member

Daniel15 commented Oct 14, 2022

@RDIL The only version of the Debian packaging code that's actually in use is in the v1 repo and in https://github.com/yarnpkg/release-infra

RDIL
RDIL previously approved these changes Oct 15, 2022
Copy link
Member

@RDIL RDIL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but should probably be looked over by others first.

Copy link
Member

@merceyz merceyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The files in scripts/dist-scripts are still in use so those need to be restored.
Ref #4960 (comment) /

cp "$REPO_DIR"/scripts/dist-scripts/* "$TEMP_DIR"/bin

@RDIL RDIL self-requested a review October 15, 2022 16:23
@jj811208
Copy link
Contributor Author

The files in scripts/dist-scripts are still in use so those need to be restored.

I recovered them 08b97b0

but I don't quite understand the timing of their use 🥹, It looks like these files have just been copied and chmod -x

- name: 'Upload the releases'
run: |
yarn config set -H 'npmAuthToken' "${{secrets.YARNBOT_NPM_TOKEN}}"
yarn config set -H 'npmRegistries["//npm.pkg.github.com"].npmAuthToken' "${{secrets.YARNBOT_TOKEN}}"
./scripts/release/02-release-builds.sh
./scripts/release/03-release-npm.sh

cp "$REPO_DIR"/scripts/dist-scripts/* "$TEMP_DIR"/bin
chmod +x "$TEMP_DIR"/bin/*

@merceyz
Copy link
Member

merceyz commented Oct 22, 2022

but I don't quite understand the timing of their use

They're used to create the @yarnpkg/cli-dist npm package for Volta.

@RDIL RDIL requested a review from arcanis October 22, 2022 14:40
@arcanis arcanis merged commit 3acf42a into yarnpkg:master Oct 24, 2022
@arcanis
Copy link
Member

arcanis commented Oct 24, 2022

Thanks @jj811208 !

@jj811208 jj811208 deleted the ci/remove-outdated-workflow branch October 29, 2022 07:08
merceyz added a commit that referenced this pull request Nov 3, 2022
* ci: delete snowpack e2e test

* ci: delete vue-cli e2e test

* revert: "Build Debian package (#379)"

This reverts commit f533868.

* fix: fixing erased files

Co-authored-by: merceyz <merceyz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants