-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: remove outdated workflow #4960
Conversation
3187981
to
825b46d
Compare
Vue-CLI also had a case-study: #964 |
@Daniel15 is any of the deb packaging code used in your build infrastructure in this repo? Just want to make sure the removal doesn't break anything. |
@RDIL The only version of the Debian packaging code that's actually in use is in the v1 repo and in https://github.com/yarnpkg/release-infra |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but should probably be looked over by others first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The files in scripts/dist-scripts
are still in use so those need to be restored.
Ref #4960 (comment) /
berry/scripts/release/03-release-npm.sh
Line 23 in 417d119
cp "$REPO_DIR"/scripts/dist-scripts/* "$TEMP_DIR"/bin |
825b46d
to
08b97b0
Compare
I recovered them 08b97b0 but I don't quite understand the timing of their use 🥹, It looks like these files have just been copied and berry/.github/workflows/release-candidate.yml Lines 63 to 68 in 417d119
berry/scripts/release/03-release-npm.sh Lines 23 to 24 in 417d119
|
They're used to create the |
Thanks @jj811208 ! |
What's the problem this PR addresses?
related #4954
remove outdated workflow
e2e-snowpack-workflow
snowpack is no longer actively maintained. https://www.snowpack.dev/
e2e-vue-cli-workflow
vue cli is in Maintenance Mode(it mean no new features will be added, only serious and common-case bugs will be fixed), and vue official is recommended to use create-vue (vite) to build vue projects. https://cli.vuejs.org/
package-workflow
This is a workflow that is no longer used
see: #4954 (comment)
...
How did you fix it?
e2e-snowpack-workflow
e2e-vue-cli-workflow
...
Checklist