Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yarn doesn't remove packages in non-empty namespace #1992

Closed
marzelin opened this issue Nov 22, 2016 · 2 comments
Closed

yarn doesn't remove packages in non-empty namespace #1992

marzelin opened this issue Nov 22, 2016 · 2 comments
Labels

Comments

@marzelin
Copy link

marzelin commented Nov 22, 2016

Bug

What is the current behavior?
When removing package that is installed with a namespace while there is at least one other package in that namespace, package directory won't be removed

If the current behavior is a bug, please provide the steps to reproduce.

yarn add @types/chai
yarn add @types/lodash
yarn remove @types/chai
ls node_modules/@types \\ output: chai/  lodash/

What is the expected behavior?
package directory should be removed from namespace folder:
ls node_modules/@types \\ output: lodash/

node.js, yarn and operating system version.
yarn version: v0.17.8 (as global package)
os: ubuntu 16.10 64-bit
node: v7.1.0

@FDiskas
Copy link

FDiskas commented Nov 22, 2016

Same problem then the files is not removed from node_modules directory on Failed install

@DenisGorbachev
Copy link
Contributor

Fixed in #2036

wyze pushed a commit that referenced this issue Nov 29, 2016
* Remove packages in non-empty namespace (#1992)

* Add a test for removing a single scoped package (#1992)

* Minimize fixtures for scoped-package test (#1992)

* Fix remove command test (#1992)

* Inline subfilepath (#1992)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants