-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yarn cannot handle "//" package #2484
Comments
Landed the fix to the popular package keyczarjs which informed me of this problem.
|
The NPM seems to handle it fine. Yarn should remove "comment" items from the loaded package.json. There are several existing libraries that can be used to do this. |
I'm taking a look at this. Hopefully can make a PR later today or tomorrow. |
Is this fixed? Example package.json: {
"name": "test",
"version": "1.0.0",
"main": "index.js",
"license": "MIT",
"dependencies": {
"//": "test"
}
} Error:
|
@bartaz the fix is on latest nightlies and will be released with 1.0 very soon. |
@BYK thanks! |
Do you want to request a feature or report a bug?
bug
What is the current behavior?
According to Isaac Schlueter, this is a valid way to add comments to your package.json: https://groups.google.com/forum/#!msg/nodejs/NmL7jdeuw0M/yTqI05DRQrIJ
Yarn 0.19.1 does not support this. You can add a package that has a package.json like this, but if you try to run yarn install after that, it will fail.
yarn-error.log:
I also tested with a non-array comment package in my package.json, in that case the error was: "Received malformed response from registry for undefined. The registry may be down."
If the current behavior is a bug, please provide the steps to reproduce.
What is the expected behavior?
yarn install works. yarn ignores the "//" package.
Please mention your node.js, yarn and operating system version.
Ubuntu 16.10
Yarn version: 0.19.1
Node version: 6.9.4
The text was updated successfully, but these errors were encountered: