-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"//" keys should be ignored in "resolution" section of package.json #4774
Labels
Comments
|
rally25rs
added a commit
to rally25rs/yarn
that referenced
this issue
Oct 25, 2017
**Summary** Previously package.json comments were being ignored for "dependencies", "devDependencies", "optionalDependencies". This change adds "resolutions" to the sections that will ignore comments. **Test Plan** Added unit test to make sure warning is not printed for a comment in a resoluton. Fixes yarnpkg#4774
BYK
pushed a commit
that referenced
this issue
Oct 26, 2017
…4779) Fixes #4774 **Summary** Previously package.json comments were being ignored for "dependencies", "devDependencies", "optionalDependencies". This change adds "resolutions" to the sections that will ignore comments. **Test Plan** Added unit test to make sure warning is not printed for a comment in a resolution.
@rally25rs Thanks! |
joaolucasl
pushed a commit
to joaolucasl/yarn
that referenced
this issue
Oct 27, 2017
…arnpkg#4779) Fixes yarnpkg#4774 **Summary** Previously package.json comments were being ignored for "dependencies", "devDependencies", "optionalDependencies". This change adds "resolutions" to the sections that will ignore comments. **Test Plan** Added unit test to make sure warning is not printed for a comment in a resolution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What is the current behavior?
"//"
keys (comments) in the"resolution"
section are not ignored.Steps to reproduce:
Add a key to the
"resolution"
section of apackage.json
like:Run
yarn install
.See warning:
What is the expected behavior?
The key should be ignored.
"//"
keys are a standard way of commenting inpackage.json
files in lieu of actual comments being available in JSON. (The"resolution"
section in particular is a place where comments are necessary, so you can communicate why you're doing heavy-handed dependency tweaking.)Please mention your node.js, yarn and operating system version.
The text was updated successfully, but these errors were encountered: