New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bundledDependencies are not handled properly causing issues and warnings #3751
Comments
Scheduled to be released in 0.28 - either revert the check or find out why a folder is copied twice |
FWIW, I've also experienced this using |
Thanks, I'll investigate + convert the check into a warning |
Pinning to 0.27.3 works for me. |
Yeah, it is only in master right now |
The problem is in bundledDependencies. |
The bug is mitigated, the PRI can be lowered |
**Summary** Refs #3751. Looks like we do multiple traversals of the file tree when doing bulk copies, resulting a run-time exception from `invariant` when we try to add the same file twice to the copy list. This patch makes that a warning instead of a hard failure until we fix the bug. **Test plan** Run `yarn add nyc@11.0.3`. Make sure it doesn't fail but you see the warning.
I think we should keep this high-prio and fix the underlying issue in 1.0 |
Still seeing these warnings on |
Still happening in v1.0.1. |
@artlogic yup, aware. Will look into this. |
not sure it it's a proper solution, remove yarn.lock then re-run yarn worked for me :) |
I am getting these warnings even with the Console output
Why would copy be required for listing globally installed modules? |
@sudo-suhas, that is a separate bug. |
@bestander I have created a separate issue for this - #4465 |
Did a yarn install today and this showed up. It also indicated I should upgrade yarn to 1.1.0, but I get the same output. warning The case-insensitive file /Users/rosnet/stafflinq-ignite/node_modules/nyc/node_modules shouldn't be copied twice in one bulk copy |
Hi everyone! No need for more "happens to me" comments since we have a fairly good understanding of why and how this happens. We'll try to get at this ASAP, and at least suppress the warning since it is not useful to you, as the users. Apologies for the trouble. In the meantime, if anyone is interested in giving this a shot until we do, feel free to ping me here or on Discord and I'd be happy to guide you! |
Related: #4275 I'd just like to point out that this is still very much an issue. Every yarn version thereafter I'm a bit concerned with why |
…gs (yarnpkg#4549) **Summary** Refs yarnpkg#3751. Changes `reporter.warn` to `reporter.verbose` for the message "The case-insensitive file ${dest} shouldn't be copied twice in one bulk copy". **Test plan** Manual verification.
There's a possibly related issue (or perhaps root cause): As of 1.3.2 bundled dependencies are double installed. Once from the bundle, in the bundling module's If the resolver ends up deciding one of those deps currently being installed at the top level has to be hoisted, I think that would cause the problems described here (with multiple of the same destination). npm, fwiw, records all of the bundled modules in its lockfile, with annotations so it knows that they're sourced from the bundling tarball, not from stand alone downloads. |
Thanks for looking into this for us, @iarna, very much appreciated! |
@iarna the issue is the complete neglect of I think blacklisting any |
m |
Closing as we've completely removed support for |
Do you want to request a feature or report a bug?
bug
What is the current behavior?
Check introduced in #3712
Another example
The text was updated successfully, but these errors were encountered: