-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
--no-git-tag-version option disables creation of a commit #8141
Comments
👍 I spent much of yesterday wondering why our CI was not pushing the updated |
What's the command to disable this permanently in the repo? Isn't there a command to set the .yarn config in the project so it doesn't clobber the git tags? This instantly breaks most monorepos. |
dueto a bug (yarnpkg/yarn#8141), the tag should not be disabled. Otherwise no commit will be crated.
Any follow up on this ? |
+1 |
2 similar comments
+1 |
+1 |
Somewhat related: What is the proper workflow for updating version in an electron-build two package.json setup as described here https://www.electron.build/tutorials/two-package-structure. Should yarn automatically update the versions of all package.json files, or should the first one be updated by yarn without commit, then the manual update of the second one, and a final commit with the proper version message? Kinda complicated. |
Bug description
It says that it disables creation of a git tag but in fact it disables the whole commit. There should probably be another option to disable the whole commit (e.g. --no-git-commit) and this option should disable only creation of a tag.
Command
What is the current behavior?
It only increases the patch number in package.json.
What is the expected behavior?
It should increase the patch number in package.json and create a commit (without adding a tag).
Steps to Reproduce
yarn version --no-git-tag-version --patch
Environment
v10.20.1
1.22.4
The text was updated successfully, but these errors were encountered: