Return SSH URL format for getGitSSHUrl #1081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@diorahman looks reasonable. |
bestander
requested changes
Oct 28, 2016
added 2 commits
October 30, 2016 10:05
At `GitFetcher._fetch` protocol should be there for the resolved URL resulted from `HostedGitResolver.getGitSSHUrl`. If not, the actual fetching process fails.
diorahman
force-pushed
the
fix-resolve-private
branch
from
64895c5
to
892ac2c
Compare
|
@bestander please let me know if you think we need more tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
At this line https://github.com/diorahman/yarn/blob/master/src/fetchers/git-fetcher.js#L20 the
GitFetcher._fetchshould have a resolved URL (from hosted, private repo) that has protocol. If not the actual fetching always falls through tofetchFromLocal.Test plan
Create a private repo on github. E.g. For my test I have https://github.com/HOOQTV/inbox and it has several releases, one of them:
v0.1.0.Then try to
yarn add github:hooqtv/inbox#v0.1.0.Before this PR:
After